Skip to content

Tweak CSSLintDemo #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2014
Merged

Tweak CSSLintDemo #489

merged 3 commits into from
Aug 21, 2014

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 10, 2014

  • Specify html lang
  • Move JS code to a separate file
  • Wrap the whole code in a window.onload
  • Use csslint.js from the build directory

@nschonni
Copy link
Member

nschonni commented Apr 10, 2014

Thanks @XhmikosR
@stubbornella is the separate demo still needed now that the csslint.net website is open?

@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 10, 2014

I personally find it useful; that's how I noticed #490 :)

nschonni added a commit that referenced this pull request Aug 21, 2014
@nschonni
Merge pull request #489 from XhmikosR/demo-split-js
c59f2e5 
Tweak CSSLintDemo
@nschonni nschonni merged commit c59f2e5 into CSSLint:master Aug 21, 2014
@nschonni nschonni added this to the 0.11.0 milestone Aug 21, 2014
@XhmikosR XhmikosR deleted the demo-split-js branch August 21, 2014 23:01
@XhmikosR XhmikosR modified the milestones: 0.11.0, 1.0.0 Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Triage

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @nschonni